Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raleway to heaven [part 2] #70

Merged
merged 13 commits into from
Aug 26, 2020
Merged

Raleway to heaven [part 2] #70

merged 13 commits into from
Aug 26, 2020

Conversation

alerque
Copy link
Member

@alerque alerque commented Aug 24, 2020

This is part of a series of PR's working on builds from UFO (and later mixed with Glyphs) sources fixing issues that come up while I work through deforking Raleway. See previously #68.

@alerque alerque force-pushed the raleway-to-heaven branch from 1785b9d to 98e513c Compare August 25, 2020 21:20
@alerque alerque marked this pull request as ready for review August 25, 2020 21:36
This got added and turned on by default upstream in superlinter but is
a super terrible idea. We use it as a hint to editors manually editing
files, but the linter can't tell the difference between our hand edited
files and autogenerated code like automake's cruft.
@alerque alerque force-pushed the raleway-to-heaven branch 2 times, most recently from 8c23cef to aebe581 Compare August 26, 2020 08:18
This complexity is kind of needed to allow projects to have custom
rules. Without it they don't have any access to the anything Fontship
initializes. They won't even be running with the same shell options as
Fontship itself, at least not on first pass.

This normalizes it so all the makefiles are on a level field.
@alerque alerque force-pushed the raleway-to-heaven branch from aebe581 to 0f43201 Compare August 26, 2020 09:08
@alerque alerque merged commit a46b34e into master Aug 26, 2020
@alerque alerque deleted the raleway-to-heaven branch August 26, 2020 09:21
This was referenced Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant