-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raleway to heaven [part 2] #70
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many input sources (especially UF) may have the same Family Name and Styles, for the sake of the project we need that list de-duplicated.
1785b9d
to
98e513c
Compare
This got added and turned on by default upstream in superlinter but is a super terrible idea. We use it as a hint to editors manually editing files, but the linter can't tell the difference between our hand edited files and autogenerated code like automake's cruft.
8c23cef
to
aebe581
Compare
This complexity is kind of needed to allow projects to have custom rules. Without it they don't have any access to the anything Fontship initializes. They won't even be running with the same shell options as Fontship itself, at least not on first pass. This normalizes it so all the makefiles are on a level field.
aebe581
to
0f43201
Compare
This was referenced Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a series of PR's working on builds from UFO (and later mixed with Glyphs) sources fixing issues that come up while I work through deforking Raleway. See previously #68.